Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cicd bugfix to save metrics result files #2592

Closed
wants to merge 2 commits into from
Closed

Feature/cicd bugfix to save metrics result files #2592

wants to merge 2 commits into from
+6 −6

Conversation

BruceKropp-Raytheon
Copy link
Collaborator

@BruceKropp-Raytheon BruceKropp-Raytheon commented Feb 6, 2025 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

The cicd scripts save performance metrics to JSON and CSV outfiles, but need to be saved to a common location in the workspace, defined by WORKSPACE env variable, or PWD when WORKSPACE is undefined.

Commit Message:

Feature/cicd bugfix to save metrics result files.

* UFSWM - cicd automation metrics

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 6, 2025

combining this pr with #2569

@jkbk2004 jkbk2004 mentioned this pull request Feb 6, 2025
Merged
14 tasks
@BruceKropp-Raytheon
Copy link
Collaborator Author

Full rt.sh tests PASS on Derecho: https://jenkins.epic.oarcloud.noaa.gov/job/ufs-weather-model/job/nightly_draft/116/s3/

jkbk2004 pushed a commit that referenced this pull request Feb 10, 2025
@NickSzapiro-NOAA @gspetro-NOAA @BruceKropp-Raytheon
Update CICE (2025-01) + Feature/cicd bugfix to save metrics result fi…
d57779f 
…les #2592 +  Remove Expanse/Odin/Stampede & Update Orion/Hercules lmod init script location #2570  (#2569)

* UFSWM - Update CICE to Consortium/main (2025-01)
* UFSWM - Rm Expanse/Stampede/Odin & update Orion/Hercules lmod init location
* UFSWM - Save cicd automation metrics in WORKSPACE
  * CICE - Update CICE to Consortium/main (2025-01)

---------

Co-authored-by: gspetro-NOAA <[email protected]>
Co-authored-by: Bruce Kropp <[email protected]>
@jkbk2004
Copy link
Collaborator

merged with #2569

@jkbk2004 jkbk2004 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankimball ankimball ankimball approved these changes

@kbooker79 kbooker79 Awaiting requested review from kbooker79

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004

@FernandoAndrade-NOAA FernandoAndrade-NOAA Awaiting requested review from FernandoAndrade-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BruceKropp-Raytheon @jkbk2004 @ankimball